Fix broken CI build #2255
Fix broken CI build #2255
Conversation
- restore code from cba07adda085fb3a8d7850f2b 53673be95196c3e - update test fixture for codemod
| @@ -1,7 +1,6 @@ | |||
| /* eslint-disable */ | |||
| import '@kadira/storybook-addons'; | |||
| import '@kadira/react-storybook-decorator-centered'; | |||
| import '@kadira/storybook-addon-comments'; | |||
There was a problem hiding this comment.
What if a project actually has this dependency? Currently it's replaced with @storybook/react-addon-comments, which is a non-existent package
There was a problem hiding this comment.
See also: cf054ad#commitcomment-25450913
There was a problem hiding this comment.
@Hypnosphi @danielduan any idea how this passed in #2189
I'm not so familiar with how our codemod works?
There was a problem hiding this comment.
#2189 doesn't change anything in codemod
There was a problem hiding this comment.
Updated codemod & test cases per your suggestions @Hypnosphi . Also ran npm deprecate
Codecov Report
@@ Coverage Diff @@
## release/3.3 #2255 +/- ##
==============================================
Coverage ? 22.66%
==============================================
Files ? 346
Lines ? 6767
Branches ? 905
==============================================
Hits ? 1534
Misses ? 4561
Partials ? 672
Continue to review full report at Codecov.
|
# Conflicts: # addons/comments/package.json # addons/knobs/package.json # addons/knobs/src/components/types/Array.js # examples/cra-kitchen-sink/package.json # package.json # yarn.lock
Issue: N/A
What I did
cba07adda085fb3a8d7850f2b
53673be95196c3e
How to test
Is this testable with jest or storyshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.